Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Use uvloop with zmq-decoupled front-end #7570

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[Core] Use uvloop with zmq-decoupled front-end #7570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vllm/entrypoints/openai/rpc/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from typing import Any, Coroutine

import cloudpickle
import uvloop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it already required by another package? It wouldn't hurt to explicitly add it to requirements-common.txt

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already installed via uvloop which is a dependency of fastapi i beleive

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fastapi recently excluded uvicorn as a dependency but uvicorn[standard] (which depends on uvloop) is already in vllm's requirements-common.txt so it is safe for now.

import zmq
import zmq.asyncio
from typing_extensions import Never
Expand Down Expand Up @@ -217,4 +218,4 @@ def signal_handler() -> None:
def run_rpc_server(async_engine_args: AsyncEngineArgs,
usage_context: UsageContext, rpc_path: str):
server = AsyncEngineRPCServer(async_engine_args, usage_context, rpc_path)
asyncio.run(run_server(server))
uvloop.run(run_server(server))
Loading