Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Add support for Python 3.12 #7035

Merged
merged 2 commits into from
Aug 2, 2024
Merged

[CI/Build] Add support for Python 3.12 #7035

merged 2 commits into from
Aug 2, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Aug 1, 2024

This builds locally for me using Python 3.12.4. This was pending on torch==2.4.0 and vllm-flash-attn==2.6.1, and those have landed now.

I have tested installing all CUDA and dev dependencies, along with running a few model tests locally.

FIX #1218
FIX #6877
FIX #6990

Copy link

github-actions bot commented Aug 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin marked this pull request as ready for review August 1, 2024 21:05
@mgoin mgoin force-pushed the add-python-3.12 branch from 0204fdb to a8a3d70 Compare August 1, 2024 21:07
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 1, 2024
@simon-mo simon-mo merged commit b482b9a into main Aug 2, 2024
64 of 66 checks passed
@simon-mo
Copy link
Collaborator

simon-mo commented Aug 2, 2024

I think this doesn't matter anymore since we shipped py38-abi agnostic version

@mgoin
Copy link
Member Author

mgoin commented Aug 2, 2024

@simon-mo This is likely true for installing the built wheel, but before this PR you couldn't build vLLM from source on 3.12 because of PYTHON_SUPPORTED_VERSIONS in the CMakeLists.txt file.

@mgoin mgoin deleted the add-python-3.12 branch August 2, 2024 22:08
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Usage]: Add support for Python 3.12 [Feature]: Support Python 3.12 Support Python 3.12
3 participants