Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] use FusedMoE layer in Jamba #6935

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

avshalomman
Copy link
Contributor

This PR replaces the Jamba-specific MoE layer impl with the standard vLLM FusedMoE layer.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@avshalomman avshalomman changed the title use FusedMoE layer in Jamba [Model] use FusedMoE layer in Jamba Jul 30, 2024
@avshalomman
Copy link
Contributor Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 30, 2024
@robertgshaw2-redhat
Copy link
Collaborator

Thanks for making this change! Did not realize Jamba had FusedMoE during the refactor

@avshalomman
Copy link
Contributor Author

I see that some tests in the extended suite are failing but they don't seem to be related

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but is there an active test in CI to ensure this works?

@avshalomman
Copy link
Contributor Author

LGTM but is there an active test in CI to ensure this works?

There are 10 general tests for the Jamba model, which pass after the change to the FusedMoE layer

@avshalomman
Copy link
Contributor Author

/ready

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the answers, LGTM

@avshalomman
Copy link
Contributor Author

Thanks for the answers, LGTM

Thanks! How can I re-run the failing tests? These seem like transient, unrelated errors

@simon-mo simon-mo merged commit 2ee8d3b into vllm-project:main Jul 31, 2024
68 of 72 checks passed
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants