-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] use FusedMoE layer in Jamba #6935
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
/ready |
Thanks for making this change! Did not realize Jamba had |
I see that some tests in the extended suite are failing but they don't seem to be related |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but is there an active test in CI to ensure this works?
There are 10 general tests for the Jamba model, which pass after the change to the FusedMoE layer |
/ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the answers, LGTM
Thanks! How can I re-run the failing tests? These seem like transient, unrelated errors |
Signed-off-by: Alvant <[email protected]>
This PR replaces the Jamba-specific MoE layer impl with the standard vLLM FusedMoE layer.