Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix decode tokens w. CUDA graph #6757

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

comaniac
Copy link
Collaborator

Fixes #6703.
This is not related to speculative decoding particularly but not sure why no unit test failed. Will try to add a unit test in this or a follow-up PR.

cc @cadedaniel @alexm-neuralmagic

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2024
@cadedaniel
Copy link
Collaborator

How do we know this fixes the issue?

@comaniac
Copy link
Collaborator Author

How do we know this fixes the issue?

I tested it locally and will add a unit test to catch this later. Just put the PR here to unblock benchmarking first.

@comaniac
Copy link
Collaborator Author

comaniac commented Jul 24, 2024

Turns out that num_decode_tokens is probably the only attribute missed in the unit test...
The new added assertion will fail without this PR.

@comaniac comaniac enabled auto-merge (squash) July 24, 2024 20:40
@simon-mo simon-mo merged commit 309aaef into vllm-project:main Jul 25, 2024
71 of 73 checks passed
@comaniac comaniac deleted the fix-input branch July 25, 2024 16:05
cadedaniel pushed a commit to cadedaniel/vllm-public that referenced this pull request Jul 27, 2024
cadedaniel pushed a commit to cadedaniel/vllm-public that referenced this pull request Jul 27, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Flash-attn on-GPU advance step optimization bug with spec decode on LLama 405B
3 participants