-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hardware][cuda] use device id under CUDA_VISIBLE_DEVICES for get_device_capability #6216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable, thanks for quick fix!
Should we replace all usages of |
I replaced most of them in #6080 . The rest are mostly used under |
@youkaichao I forget where but I ran into CI issues with |
links would be appreciated. I don't think cpu code should call this function. even before this change, |
@comaniac these should be called after process initialize cuda, so they are fine. we can also replace them, though. |
Yeah it would be safer to replace this one as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge first. I'll change the use in selector in another PR. |
…ice_capability (vllm-project#6216) Signed-off-by: Alvant <[email protected]>
fixes #6213