Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GPT-2 #60

Merged
merged 8 commits into from
May 4, 2023
Merged

Add support for GPT-2 #60

merged 8 commits into from
May 4, 2023

Conversation

WoosukKwon
Copy link
Collaborator

Closes #55

@WoosukKwon WoosukKwon requested a review from zhuohan123 May 3, 2023 20:16
Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@WoosukKwon WoosukKwon merged commit e548c14 into main May 4, 2023
@WoosukKwon WoosukKwon deleted the gpt-2 branch May 4, 2023 09:59
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
JHLEE17 pushed a commit to JHLEE17/vllm that referenced this pull request Aug 1, 2024
@alixiaodi alixiaodi mentioned this pull request Aug 2, 2024
maxdebayser added a commit to maxdebayser/vllm that referenced this pull request Feb 13, 2025
…ject#60)

Some models such as `sentence-transformers/all-MiniLM-L12-v2` don't have
special tokens such as "bos_token" in their tokenizer configuration.
This causes a key error when the warmup logic tries to get the id for
these tokens. However, since the IDs are only used to exclude them from
the set of tokens that can be generated during the warmup, it doesn't
make a difference if they don't exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GPT-2
2 participants