-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add multiproc_worker_utils
for multiprocessing-based workers
#4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mechanics for running multiprocessing-based worker processes and dispatching tasks to them via multiprocessing queues. The class ProcessWorkerWrapper is equivalent to RayWorkerWrapper. Each ProcessWorkerWrapper has a task queue for passing tasks to the corresponding worker process. There is a shared result queue for receiving the results from all worker processes. ResultHandler is a thread that processes this result queue, completing the corresponding waiting futures as results come in. WorkerMonitor is a thread that uses the multiprocessing wait() method to monitor the state of all worker processes and tear things down cleanly if any exit unexpectedly - including completing all waiting futures with an error and terminating the remaining processes. _run_worker_process is the function that runs in each of the worker processes, in a loop waiting on their corresponding task queue. This is in preparation for a MultiprocessingGPUExecutor.
njhill
commented
Apr 25, 2024
@zhuohan123 this is the file we already talked through, with some minor updates:
|
njhill
commented
Apr 25, 2024
Closed
njhill
commented
May 1, 2024
zhuohan123
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a small comment.
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 6, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 7, 2024
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mechanics for running multiprocessing-based worker processes and dispatching tasks to them via multiprocessing queues.
The class
ProcessWorkerWrapper
is equivalent toRayWorkerWrapper
.Each
ProcessWorkerWrapper
has a task queue for passing tasks to the corresponding worker process.There is a shared result queue for receiving the results from all worker processes.
ResultHandler
is a thread that processes this result queue, completing the corresponding waiting futures as results come in.WorkerMonitor
is a thread that uses the multiprocessingwait()
method to monitor the state of all worker processes and tear things down cleanly if any exit unexpectedly - including completing all waiting futures with an error and terminating the remaining processes._run_worker_process
is the function that runs in each of the worker processes, in a loop waiting on their corresponding task queue.This is in preparation for a
MultiprocessingGPUExecutor
.