Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] More type hint fixes for py 3.8 #4039

Merged
merged 1 commit into from
Apr 13, 2024
Merged

[Bugfix] More type hint fixes for py 3.8 #4039

merged 1 commit into from
Apr 13, 2024

Conversation

dylanwhawk
Copy link
Contributor

FIX #4035

#4036 didn't fix all of the type annotations from #3837

youkaichao
youkaichao approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we will introduce mypy soon. Hope this will not happen again.

@youkaichao youkaichao enabled auto-merge (squash) April 12, 2024 20:23
@simon-mo simon-mo merged commit 5c2e66e into vllm-project:main Apr 13, 2024
32 of 35 checks passed
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 21, 2024
@dylanwhawk @robertgshaw2-redhat
[Bugfix] More type hint fixes for py 3.8 (vllm-project#4039)
377437f
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 21, 2024
@dylanwhawk @robertgshaw2-redhat
[Bugfix] More type hint fixes for py 3.8 (vllm-project#4039)
808fdff
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request Apr 22, 2024
@dylanwhawk @joerunde
[Bugfix] More type hint fixes for py 3.8 (vllm-project#4039)
73d1303
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 26, 2024
@dylanwhawk @robertgshaw2-redhat
[Bugfix] More type hint fixes for py 3.8 (vllm-project#4039)
0356684
@dtrifiro dtrifiro mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@youkaichao youkaichao youkaichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect typing for Python 3.8
3 participants
@dylanwhawk @simon-mo @youkaichao