[Core][Distributed] make init_distributed_environment compatible with init_process_group #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
approved these changes
Apr 11, 2024
njhill
reviewed
Apr 11, 2024
| distributed_init_method: Optional[str] = None, | ||
| world_size: int = -1, | ||
| rank: int = -1, | ||
| distributed_init_method: str = "env://", |
There was a problem hiding this comment.
@youkaichao shouldn't the type here remain as Optional[str] since presumably it could still be valid to pass None?
There was a problem hiding this comment.
for compatibility, yes, Optional[str] is better. but does anyone really explictly pass None? I don't want to do an extra check if distributed_init_method is None 🤣
andy-neuma
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 12, 2024
…m-project#4014) [Core][Distributed] make init_distributed_environment compatible with init_process_group (vllm-project#4014)
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
Apr 22, 2024
…m-project#4014) [Core][Distributed] make init_distributed_environment compatible with init_process_group (vllm-project#4014)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we require
world_sizeandrank, but we can make them optional, and have a defaultdistributed_init_methodtoenv://.This way, the following code just works with
torchrun, which makes test and development very convenient.This should not affect other part of the code, as it only provides some default value for the function.
I do think we can change the arg name
distributed_init_methodtoinit_method, which is more aligned with pytorch. But that will require more code change. Not sure if it is worth the change.cc @zhuohan123 for opinions.