[WIP][Core][Refactor] move vllm/model_executor/parallel_utils into vllm/distributed and vllm/device_communicators #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
reviewed
Apr 9, 2024
vllm/utils.py
Outdated
Comment on lines
475
to
477
| from typing import Sequence | ||
|
|
||
| import torch |
There was a problem hiding this comment.
Or move the utils to vllm/distributed/utils.py
vllm/parallel_state.py
Outdated
There was a problem hiding this comment.
Can you create a distributed folder for parallel_state.py and distributed.py?
zhuohan123
approved these changes
Apr 10, 2024
SageMoore
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 11, 2024
…ect#3950) [WIP][Core][Refactor] move vllm/model_executor/parallel_utils into vllm/distributed and vllm/device_communicators (vllm-project#3950)
andy-neuma
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Apr 12, 2024
…ect#3950) [WIP][Core][Refactor] move vllm/model_executor/parallel_utils into vllm/distributed and vllm/device_communicators (vllm-project#3950)
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
Apr 22, 2024
…ect#3950) [WIP][Core][Refactor] move vllm/model_executor/parallel_utils into vllm/distributed and vllm/device_communicators (vllm-project#3950)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't place
vllm/device_communicatorsundervllm/distributed/device_communicators, because device communicators can also be used in a single process.Main idea of the change:
vllm/model_executor/parallel_utils/parallel_state.pyandvllm/model_executor/parallel_utils/communication_op.py-->vllm/distributed.pythe rest: -->
vllm/device_communicatorsSeek for suggestions @zhuohan123 , let's discuss the structure of refactor first, then fix test and linter.