Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixing requirements.txt #3865

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

noamgat
Copy link
Contributor

@noamgat noamgat commented Apr 5, 2024

Pip requires a comma between multiple version requirements in a single line. This small fix makes
pip install -e .
work again.

Fixing the way pip requires multiple version specifications
@WoosukKwon WoosukKwon requested a review from youkaichao April 5, 2024 06:34
@youkaichao
Copy link
Member

really? currently it works though, without this fix.

@WoosukKwon
Copy link
Collaborator

@youkaichao I checked that the current one doesn't work with pip install -e .:

  error: subprocess-exited-with-error
  
  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [5 lines of output]
      /tmp/pip-build-env-yb6olylr/overlay/lib/python3.10/site-packages/torch/nn/modules/transformer.py:20: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:84.)
        device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),
      error in vllm setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected end or semicolon (after version specifier)
          vllm-nccl-cu12>=2.18<2.19

@youkaichao
Copy link
Member

Okay, I see it from https://packaging.python.org/en/latest/specifications/version-specifiers/#id5 . Thanks for the fix!

@WoosukKwon WoosukKwon changed the title Fixing requirements.txt [Bugfix] Fixing requirements.txt Apr 5, 2024
@WoosukKwon WoosukKwon merged commit 9edec65 into vllm-project:main Apr 5, 2024
5 of 8 checks passed
@noamgat noamgat deleted the patch-1 branch April 5, 2024 07:19
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants