-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Define common requirements #3841
Conversation
Tbh, I'm not sure whether introducing Alternatively, we can duplicate the contents of
while
|
@WoosukKwon you can ref one requirements file from another, so
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WoosukKwon, I really like the de-duplication!
@WoosukKwon #3859 is merged. If you merge main into this PR, it should resolve the vllm-nccl problem. |
This PR factors out the common dependencies to
requirements-common.txt
to better manage the dependencies across different backends.