Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support block size 32 #35

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Support block size 32 #35

merged 2 commits into from
Apr 10, 2023

Conversation

WoosukKwon
Copy link
Collaborator

This PR adds support for block size 32. It turns out that no modification to our attention kernel is required for this support.

@WoosukKwon WoosukKwon merged commit b9926f7 into main Apr 10, 2023
@WoosukKwon WoosukKwon deleted the block-size branch April 10, 2023 06:07
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
tianyil1 pushed a commit to tianyil1/vllm that referenced this pull request Jun 5, 2024
fxmarty pushed a commit to fxmarty/vllm-public that referenced this pull request Jun 12, 2024
…ge_with_newer_pytorch

Update base docker image with Pytorch 2.3
joerunde added a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
…ch instead. (vllm-project#35)

I tested the previous fix for the Triton cache collision issue (see:
vllm-project#34) and it didn't work.

I now see errors like:
```
FileNotFoundError: [Errno 2] No such file or directory: '/home/vllm/.triton/cache/1feb415f3280ca46eea8c4407a58c23e/fused_moe_kernel.json.tmp.pid_72_c0a0033e-6147-4520-ae3a-3847d02598f8'
```
which now shows the `uuid` instead of a random integer, but problem
remains.

This PR implements a different workaround, proposed by @cyang49, that
tells Triton to use a custom cache manager which assigns a different
directory based on the process id.

This time I have tested it and it seems to work.

---------

Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Joe Runde <[email protected]>
Co-authored-by: Chih-Chieh-Yang <[email protected]>
Co-authored-by: Joe Runde <[email protected]>
Co-authored-by: Nick Hill <[email protected]>
bigPYJ1151 pushed a commit to bigPYJ1151/vllm that referenced this pull request Jul 30, 2024
@alixiaodi alixiaodi mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant