Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix prefix test error on main #3286

Merged
merged 1 commit into from
Mar 9, 2024
Merged

[FIX] Fix prefix test error on main #3286

merged 1 commit into from
Mar 9, 2024

Conversation

zhuohan123
Copy link
Member

No description provided.

@zhuohan123 zhuohan123 requested a review from WoosukKwon March 8, 2024 18:27
WoosukKwon
WoosukKwon approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@zhuohan123 zhuohan123 enabled auto-merge (squash) March 8, 2024 18:56
@zhuohan123 zhuohan123 disabled auto-merge March 9, 2024 01:16
@zhuohan123 zhuohan123 merged commit f48c679 into main Mar 9, 2024
23 checks passed
@WoosukKwon WoosukKwon mentioned this pull request Mar 12, 2024
Closed
dtransposed pushed a commit to afeldman-nm/vllm that referenced this pull request Mar 26, 2024
@zhuohan123
[FIX] Fix prefix test error on main (vllm-project#3286)
cd9b20d
@zhuohan123 zhuohan123 deleted the fix-main-test-error branch April 26, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhuohan123 @WoosukKwon