[Quality] Add code formatter and linter #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
changed the title
zhuohan123
changed the title
|
@WoosukKwon This PR is ready for review. Let's decide when is a good time to merge the formatter. |
WoosukKwon
requested changes
Jul 3, 2023
WoosukKwon
approved these changes
Jul 3, 2023
|
how to add history argument？ |
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
yukavio
pushed a commit
to yukavio/vllm
that referenced
this pull request
Jul 3, 2024
SUMMARY: * updated hf lm-eval gsm baseline script to use accelerate, enabling us to generate baselines on big models' * added vllm lm-eval gsm baseline script for scenarios that hf does not support (e.g. fp8) * added lm-eval GSM model configs for broad set of models (small + large) * refactored smoke / full configs to reference the model configs + trigger one test at a time * refactored lm-eval accuracy test to avoid using ray to launch server, which caused issues cleaning up in server case * moved configs into `.github` folder so they are closer to the scripts FOLLOW UP PRS: * enable distributed * enable H100 for large models * eliminate the `neuralmagic` directory
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #57. Adding formatter and linter.
TODO: Add formatter into CI.