Store eos_token_id in Sequence for easy access
#3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store eos_token_id in Sequence since it's accessed so frequently.
Yard1
requested review from
WoosukKwon and
Yard1
and removed request for
WoosukKwon
Yard1
changed the title
eos_token_id in Sequence for easy access
njhill
added a commit
to njhill/vllm
that referenced
this pull request
Mar 9, 2024
vllm-project#3166 included a change to avoid applying best_of logic when there's a single sequence, but it incorrectly checks for n==1 rather than len(seqs)==1.
dtransposed
pushed a commit
to afeldman-nm/vllm
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store
eos_token_idin Sequence since it's accessed so frequently.