-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate InternLMForCausalLM to LlamaForCausalLM #2860
Merged
WoosukKwon
merged 3 commits into
vllm-project:main
from
pcmoritz:migrate-internlm-model
Feb 14, 2024
Merged
Migrate InternLMForCausalLM to LlamaForCausalLM #2860
WoosukKwon
merged 3 commits into
vllm-project:main
from
pcmoritz:migrate-internlm-model
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Roy <[email protected]>
WoosukKwon
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR!
WoosukKwon
pushed a commit
that referenced
this pull request
Feb 14, 2024
jvmncs
pushed a commit
to jvmncs/vllm
that referenced
this pull request
Feb 14, 2024
Co-authored-by: Roy <[email protected]>
jvmncs
pushed a commit
to jvmncs/vllm
that referenced
this pull request
Feb 14, 2024
masahi
reviewed
Feb 14, 2024
@@ -179,6 +180,7 @@ def __init__( | |||
rope_scaling=rope_scaling, | |||
max_position_embeddings=max_position_embeddings, | |||
linear_method=linear_method, | |||
bias=getattr(config, "bias", False), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be "attention_bias"? (Note they use the term in a different sense compared to the conventional one)
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Feb 20, 2024
Co-authored-by: Roy <[email protected]>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Feb 20, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Feb 22, 2024
Co-authored-by: Roy <[email protected]>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Feb 22, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 4, 2024
Co-authored-by: Roy <[email protected]>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 4, 2024
coolCatalyst
added a commit
to coolCatalyst/vllm
that referenced
this pull request
Jun 1, 2024
shaojiewang
pushed a commit
to shaojiewang/vllm-rocm
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between InternLM and Llama is very small, just the bias for the attention layer.
For maintainability and to make things like LoRA support more uniform, this PR merges the two models. There should be no user-visible change.
This was proposed by @esmeetu in #2637 who is a coauthor of this PR.
Here is the diff between the models: