Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic attention kernel that supports cached KV + (multi-)prompts #24

Merged
merged 25 commits into from
Apr 5, 2023

Conversation

suquark
Copy link
Contributor

@suquark suquark commented Apr 3, 2023

This PR implements a basic and not highly optimized kernel to support cached KV with multiple import prompts.

@suquark suquark requested a review from WoosukKwon April 3, 2023 12:28
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your effort. Left minor comments.

@suquark suquark requested a review from WoosukKwon April 3, 2023 22:37
@suquark
Copy link
Contributor Author

suquark commented Apr 4, 2023

@WoosukKwon any comments?

@WoosukKwon
Copy link
Collaborator

Thanks @suquark for this effort. Let's merge this!

@suquark suquark merged commit 21b3671 into main Apr 5, 2023
@suquark suquark deleted the mixed_attn_kernel branch April 5, 2023 03:34
slyalin pushed a commit to slyalin/vllm that referenced this pull request Apr 4, 2024
z103cb referenced this pull request in z103cb/opendatahub_vllm May 9, 2024
`format.sh` now has mypy checks after pulling in upstream changes. This
PR makes the mypy suggested modifications to our code.

---------

Signed-off-by: Travis Johnson <[email protected]>
z103cb referenced this pull request in z103cb/opendatahub_vllm May 9, 2024
`format.sh` now has mypy checks after pulling in upstream changes. This
PR makes the mypy suggested modifications to our code.

---------

Signed-off-by: Travis Johnson <[email protected]>
z103cb referenced this pull request in opendatahub-io/vllm May 9, 2024
`format.sh` now has mypy checks after pulling in upstream changes. This
PR makes the mypy suggested modifications to our code.

---------

Signed-off-by: Travis Johnson <[email protected]>
dtrifiro pushed a commit to dtrifiro/vllm that referenced this pull request May 21, 2024
@alixiaodi alixiaodi mentioned this pull request Aug 2, 2024
njhill pushed a commit to njhill/vllm that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants