Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncation support for recent Mistrals to prevent AsyncEngineDeadError on input exceeding max_model_len w/ chunked prefill #13741

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nightflight-dk
Copy link

@nightflight-dk nightflight-dk commented Feb 24, 2025

Contrary to other tokenizers, MistralTokenizer (as used by vLLM) always has the truncation config disabled, with upstream kwargs ignored. Crashing engines with excessive input can easily crash the background threads and lead to AsyncEngineDeadError in the foreground thread.

to reproduce, run vLLM with a recent Mistral, reduce the max_model_len and enable chunked prefill, then submit requests larger than 1000 tokens.

{
"model": "mistralai/Mistral-Small-24B-Instruct-2501",
"disable_log_requests": "true",
"gpu_memory_utilization": 0.9,
"max_model_len": 1000,
"tensor_parallel_size": 1,
"enable_chunked_prefill": "true",
"enable_lora": "true",
"max_num_seqs": 8
}

SOLUTION: tokenize with truncation before submitting - but MistralTokenizer as wrapped by vLLM needs to allow it.

FIX #5901

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@nightflight-dk nightflight-dk changed the title Truncation support in MistralTokenizer to prevent AsyncEngineDeadError on input exceeding max_model_len w/ chunked prefill Truncation support for recent Mistrals to prevent AsyncEngineDeadError on input exceeding max_model_len w/ chunked prefill Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TRACKING ISSUE: AsyncEngineDeadError
1 participant