Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Kernel] Flashinfer MLA support #13630

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Feb 20, 2025

CUDA graphs still broken

Based off: #12639

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 20, 2025
@yzh119
Copy link

yzh119 commented Feb 23, 2025

Hi @LucasWilkinson , thank you for the great work!

Would you mind trying the https://github.com/flashinfer-ai/flashinfer/releases/tag/v0.2.2 where we fixed some potential bugs for cudagraph and also add a new template for hopper (flashinfer-ai/flashinfer#887).

@LucasWilkinson LucasWilkinson removed the v1 label Feb 24, 2025
@mergify mergify bot added the v1 label Feb 24, 2025
Copy link

mergify bot commented Feb 24, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LucasWilkinson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 24, 2025
Signed-off-by: Lucas Wilkinson <[email protected]>

wip flash-infer

Signed-off-by: Lucas Wilkinson <[email protected]>

wip debugging

Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
@LucasWilkinson
Copy link
Collaborator Author

Hi @LucasWilkinson , thank you for the great work!

Would you mind trying the https://github.com/flashinfer-ai/flashinfer/releases/tag/v0.2.2 where we fixed some potential bugs for cudagraph and also add a new template for hopper (flashinfer-ai/flashinfer#887).

Thank you for your amazing work, big fan of flashinfer! Very quickly tested it and im still having coda-graph issues but ill definitely play with it more tmrw and keep you up to date here 👍

Copy link

mergify bot commented Feb 25, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LucasWilkinson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants