Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chunked prefill): don't schedule prefill if freeing kv cache #13539

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

toslunar
Copy link
Contributor

@toslunar toslunar commented Feb 19, 2025

FIX #5578

This PR makes the priority "running > swapped > waiting" strict. The previous code has chance to schedule new prefills even if preemption/swap happens or there's a swapped request, which (unintentionally) changes the order of requests.

#3853 says

1. Schedule all decodes
2. Schedule all chunked prefills (running prefills)
3. Schedule swapped
4. Schedule new prefills

and it has been implemented that (3.) is skipped if (1.) or (2.) fails to schedule all. The new change is to skip (4.) if any previous step fails to schedule all.

Re-adding preempted requests to chunked prefill may be OK but it seems better to implement "partial preemption" of a sequence (i.e. freeing some tail part of KV cache), which is out of scope of the PR.


The previous PR is #5633. The commits there are squashed into the first commit here.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a style comment.

@comaniac
Copy link
Collaborator

btw can you add a unit test?

Co-authored-by: Cody Yu <[email protected]>
Signed-off-by: Toshiki Kataoka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: chunked prefill scheudler uses up swap on many n>=2 requests
2 participants