fix(chunked prefill): don't schedule prefill if freeing kv cache #13539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #5578
This PR makes the priority "running > swapped > waiting" strict. The previous code has chance to schedule new prefills even if preemption/swap happens or there's a swapped request, which (unintentionally) changes the order of requests.
#3853 says
and it has been implemented that (3.) is skipped if (1.) or (2.) fails to schedule all. The new change is to skip (4.) if any previous step fails to schedule all.
Re-adding preempted requests to chunked prefill may be OK but it seems better to implement "partial preemption" of a sequence (i.e. freeing some tail part of KV cache), which is out of scope of the PR.
The previous PR is #5633. The commits there are squashed into the first commit here.