Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Check space in the file names in the pre commit checks #12804

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[MISC] Check space in the file names in the pre commit checks #12804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,9 @@ repos:
language: system
verbose: true
pass_filenames: false
- id: check-filenames
name: Check for spaces in all filenames
entry: bash -c 'git ls-files | grep " " && echo "Filenames should not contain spaces!" && exit 1 || exit 0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it nicer if we split it into multiple lines like the signoff-commit line?

Suggested change
entry: bash -c 'git ls-files | grep " " && echo "Filenames should not contain spaces!" && exit 1 || exit 0'
entry: bash
args:
- -c
- 'git ls-files | grep " " && echo "Filenames should not contain spaces!" && exit 1 || exit 0'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, followed up in #12880

language: system
always_run: true
pass_filenames: false
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.
0 ...type=fp8_w8a8,block_shape=[128, 128].json → ...dtype=fp8_w8a8,block_shape=[128,128].json
View file
Open in desktop
File renamed without changes.