Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix AMD build error #12677

Closed
wants to merge 1 commit into from
Closed

[ci] Fix AMD build error #12677

wants to merge 1 commit into from

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Feb 3, 2025

@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 3, 2025
@youkaichao youkaichao requested a review from russellb February 3, 2025 06:19
@DarkLight1337
Copy link
Member

I think we might need to exclude this file from the pre-commit step

@russellb
Copy link
Member

russellb commented Feb 3, 2025

#12694 provides a more complete fix for this. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants