Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Pipe attn_logits_soft_cap through paged attention TPU kernels #12294

Closed
wants to merge 0 commits into from

Conversation

fenghuizhang
Copy link
Contributor

@fenghuizhang fenghuizhang commented Jan 22, 2025

Pipe attn_logits_soft_cap through paged_attention, this will unblock some of our models' adoption.

Note that the changed code currently doesn't have unit tests. I will add one later.

Signed-off-by: Fenghui Zhang [email protected]

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@fenghuizhang fenghuizhang changed the title Pipe attn_logits_soft_cap through paged attention [Kernel] Pipe attn_logits_soft_cap through paged attention Jan 22, 2025
@fenghuizhang fenghuizhang changed the title [Kernel] Pipe attn_logits_soft_cap through paged attention [Kernel] Pipe attn_logits_soft_cap through paged attention TPU kernels Jan 22, 2025
@robertgshaw2-redhat
Copy link
Collaborator

Can you add a correctness test for gemma in the ci so this codepath is flexed? Thanks!

@mgoin
Copy link
Member

mgoin commented Jan 22, 2025

Ditto, LGTM when we can add test case to CI

@fenghuizhang
Copy link
Contributor Author

Thanks for the quick turnaround.

I think CI (https://buildkite.com/vllm/fastcheck/builds/12156#01948bc4-58cd-4863-9eca-e2ea098879f9) exposed another issue in pt/xla code, I sent pytorch/xla#8600 to fix it and will verify things there first.

Will come back to this PR afterwards.

@mergify mergify bot added the ci/build label Jan 23, 2025
@fenghuizhang
Copy link
Contributor Author

Local tests with the latest pt/xla code pass now, we may need to update the nightly build label for CI to pass:

PYTHONPATH=/home/fhzhang/xla python3 examples/offline_inference/tpu.py

The error in https://buildkite.com/vllm/fastcheck/builds/12156#01948bc4-58cd-4863-9eca-e2ea098879f9 went away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants