-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache watermark to avoid frequent cache eviction #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zhuohan123 I'm merging this PR as it does not conflict with any other and it (slightly) improves the system performance. |
bigPYJ1151
pushed a commit
to bigPYJ1151/vllm
that referenced
this pull request
Sep 12, 2023
* add pos_encoding impl * add benchmark and add open mp parallel
xiangyuT
pushed a commit
to xiangyuT/vllm
that referenced
this pull request
Oct 25, 2023
* Comments done above worker * format * fixed missing arguments * fix * format
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
luo-cheng2021
pushed a commit
to luo-cheng2021/vllm
that referenced
this pull request
Mar 25, 2024
Compress model to int8
ykim362
pushed a commit
to ykim362/vllm
that referenced
this pull request
Jun 17, 2024
Wenxh/fp8 on a100 v1 pr
Closed
zeroorhero
pushed a commit
to zeroorhero/vllm
that referenced
this pull request
Sep 23, 2024
1 task
1 task
Xaenalt
pushed a commit
to Xaenalt/vllm
that referenced
this pull request
Jan 15, 2025
Add OWNERS file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the watermark mechanism to prevent frequent preemption.
If we admit new sequences such that the GPU KV cache becomes full, preemptions are highly likely to happen in the next few steps. Instead, we can reserve a small portion of the cache and refrain from utilizing the entire cache space when admitting new sequences. This will help us avoid the inefficiencies.