Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fixed parameter “n” not work when set parameter “bestof” > 1 #10854

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[bugfix] fixed parameter “n” not work when set parameter “bestof” > 1 #10854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions vllm/sampling_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,9 @@ def __post_init__(self) -> None:
raise ValueError(
f"best_of must be greater than or equal to n, "
f"got n={self.n} and best_of={self.best_of}.")
self._real_n = self.n
self.n = self.best_of
if not self._real_n:
self._real_n = self.n
self.n = self.best_of

if 0 < self.temperature < _MAX_TEMP:
logger.warning(
Expand Down
Loading