Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kernel] Update vllm-flash-attn version #10742

Merged
merged 2 commits into from
Nov 28, 2024
Merged

[Kernel] Update vllm-flash-attn version #10742

merged 2 commits into from
Nov 28, 2024

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Nov 28, 2024 •
edited
Loading

Upgrades to vllm-project/flash-attention#30, which will help reduce CPU overheads in launching the kernels.

@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 28, 2024
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 28, 2024
@WoosukKwon WoosukKwon mentioned this pull request Nov 28, 2024
Merged
@mergify Mergify
Copy link

mergify bot commented Nov 28, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @WoosukKwon.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 28, 2024
@WoosukKwon
fix
892cdce 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon WoosukKwon changed the title test [Kernel] Update vllm-flash-attn version Nov 28, 2024
@mergify mergify bot removed the needs-rebase label Nov 28, 2024
@WoosukKwon
Update
677ceb2 
Signed-off-by: Woosuk Kwon <[email protected]>
@WoosukKwon WoosukKwon merged commit 8c1e77f into main Nov 28, 2024
9 of 14 checks passed
@WoosukKwon WoosukKwon deleted the test-fa branch November 28, 2024 16:31
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
@WoosukKwon @afeldman-nm
[Kernel] Update vllm-flash-attn version to reduce CPU overheads (vllm…
1362dac 
…-project#10742)

Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@WoosukKwon
[Kernel] Update vllm-flash-attn version to reduce CPU overheads (vllm…
5496147 
…-project#10742)

Signed-off-by: Woosuk Kwon <[email protected]>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@WoosukKwon @BKitor
[Kernel] Update vllm-flash-attn version to reduce CPU overheads (vllm…
f5aa6cf 
…-project#10742)

Signed-off-by: Woosuk Kwon <[email protected]>
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 12, 2025
@WoosukKwon @anko-intel
[Kernel] Update vllm-flash-attn version to reduce CPU overheads (vllm…
c71b17d 
…-project#10742)

Signed-off-by: Woosuk Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WoosukKwon