Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] do not read HOST_IP #10644

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[misc] do not read HOST_IP #10644

merged 1 commit into from
Nov 26, 2024

Conversation

youkaichao
Copy link
Member

Signed-off-by: youkaichao <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change lgtm.

It would be nice to have a place to capture release notes for changes in behavior, deprecation notices, etc. That's not something to solve in this PR, though ...

@youkaichao
Copy link
Member Author

It would be nice to have a place to capture release notes for changes in behavior, deprecation notices, etc.

cc @simon-mo

@russellb
Copy link
Member

It would be nice to have a place to capture release notes for changes in behavior, deprecation notices, etc.

cc @simon-mo

some options:

  1. A CHANGELOG.md file in the tree where PRs can add notes as part of the PR.
  2. A commit message (PR description) convention that can be parsed out of the git commit log. Something like "VLLM-Release-Note: ". Then a script can extract it from the commits since the last release.

Since we don't have anything like #2 going already, I think #1 is probably more reasonable. The biggest downside to #1 is that it creates a place that will cause PRs to go into conflict when they're all trying to add a note to the same spot in the same file. It depends on how often the notes get added, and the conflicts are easy to fix, at least.

I can propose a file to start this in a follow-up PR to this one, using this PR as an example of one that could have included a note. Just let me know if you like the idea.

@youkaichao youkaichao merged commit 6e9ff05 into vllm-project:main Nov 26, 2024
22 of 24 checks passed
@youkaichao youkaichao deleted the host_ip branch November 26, 2024 01:04
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants