-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] do not read HOST_IP #10644
[misc] do not read HOST_IP #10644
Conversation
Signed-off-by: youkaichao <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change lgtm.
It would be nice to have a place to capture release notes for changes in behavior, deprecation notices, etc. That's not something to solve in this PR, though ...
cc @simon-mo |
some options:
Since we don't have anything like #2 going already, I think #1 is probably more reasonable. The biggest downside to #1 is that it creates a place that will cause PRs to go into conflict when they're all trying to add a note to the same spot in the same file. It depends on how often the notes get added, and the conflicts are easy to fix, at least. I can propose a file to start this in a follow-up PR to this one, using this PR as an example of one that could have included a note. Just let me know if you like the idea. |
Signed-off-by: youkaichao <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
see #10492 (comment)