Skip to content

Commit

Permalink
allow ca in pp
Browse files Browse the repository at this point in the history
  • Loading branch information
youkaichao committed Jul 3, 2024
1 parent 7cd2ebb commit f8fe2bf
Showing 1 changed file with 5 additions and 11 deletions.
16 changes: 5 additions & 11 deletions vllm/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -723,17 +723,11 @@ def _verify_args(self) -> None:
if self.distributed_executor_backend == "ray":
from vllm.executor import ray_utils
ray_utils.assert_ray_available()
if not self.disable_custom_all_reduce and self.world_size > 1:
if is_hip():
self.disable_custom_all_reduce = True
logger.info(
"Disabled the custom all-reduce kernel because it is not "
"supported on AMD GPUs.")
elif self.pipeline_parallel_size > 1:
self.disable_custom_all_reduce = True
logger.info(
"Disabled the custom all-reduce kernel because it is not "
"supported with pipeline parallelism.")
if is_hip():
self.disable_custom_all_reduce = True
logger.info(
"Disabled the custom all-reduce kernel because it is not "
"supported on AMD GPUs.")
if self.ray_workers_use_nsight and (
not self.distributed_executor_backend == "ray"):
raise ValueError("Unable to use nsight profiling unless workers "
Expand Down

0 comments on commit f8fe2bf

Please sign in to comment.