-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] add imagePullSecrets option to helm chart #179
Open
kalantar
wants to merge
1
commit into
vllm-project:main
Choose a base branch
from
kalantar:imagepullsecret
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Kalantar <[email protected]>
ApostaC
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you edit the values.yaml a bit to add the imagePullSecrets
into the comments?
See here:
production-stack/helm/values.yaml
Lines 12 to 85 in c10a2c2
# modelSpec - configuring multiple serving engines deployments that runs different models | |
# Each entry in the modelSpec array should contain the following fields: | |
# - name: (string) The name of the model, e.g., "example-model" | |
# - repository: (string) The repository of the model, e.g., "vllm/vllm-openai" | |
# - tag: (string) The tag of the model, e.g., "latest" | |
# - modelURL: (string) The URL of the model, e.g., "facebook/opt-125m" | |
# | |
# - replicaCount: (int) The number of replicas for the model, e.g. 1 | |
# - requestCPU: (int) The number of CPUs requested for the model, e.g. 6 | |
# - requestMemory: (string) The amount of memory requested for the model, e.g., "16Gi" | |
# - requestGPU: (int) The number of GPUs requested for the model, e.g., 1 | |
# | |
# - pvcStorage: (Optional, string) The amount of storage requested for the model, e.g., "50Gi". | |
# - pvcAccessMode: (Optional, list) The access mode policy for the mounted volume, e.g., ["ReadWriteOnce"] | |
# - storageClass: (Optional, String) The storage class of the PVC e.g., "", default is "" | |
# - pvcMatchLabels: (Optional, map) The labels to match the PVC, e.g., {model: "opt125m"} | |
# | |
# - vllmConfig: (optional, map) The configuration for the VLLM model, supported options are: | |
# - enablePrefixCaching: (optional, bool) Enable prefix caching, e.g., false | |
# - enableChunkedPrefill: (optional, bool) Enable chunked prefill, e.g., false | |
# - maxModelLen: (optional, int) The maximum model length, e.g., 16384 | |
# - dtype: (optional, string) The data type, e.g., "bfloat16" | |
# - tensorParallelSize: (optional, int) The degree of tensor parallelism, e.g., 2 | |
# - extraArgs: (optional, list) Extra command line arguments to pass to vLLM, e.g., ["--disable-log-requests"] | |
# | |
# - lmcacheConfig: (optional, map) The configuration of the LMCache for KV offloading, supported options are: | |
# - enabled: (optional, bool) Enable LMCache, e.g., true | |
# - cpuOffloadingBufferSize: (optional, string) The CPU offloading buffer size, e.g., "30" | |
# | |
# - hf_token: (optional, string) the Huggingface tokens for this model | |
# | |
# - env: (optional, list) The environment variables to set in the container, e.g., your HF_TOKEN | |
# | |
# - nodeSelectorTerms: (optional, list) The node selector terms to match the nodes | |
# | |
# - shmSize: (optional, string) The size of the shared memory, e.g., "20Gi" | |
# | |
# Example: | |
# modelSpec: | |
# - name: "mistral" | |
# repository: "lmcache/vllm-openai" | |
# tag: "latest" | |
# modelURL: "mistralai/Mistral-7B-Instruct-v0.2" | |
# replicaCount: 1 | |
# | |
# requestCPU: 10 | |
# requestMemory: "64Gi" | |
# requestGPU: 1 | |
# | |
# pvcStorage: "50Gi" | |
# pvcAccessMode: | |
# - ReadWriteOnce | |
# pvcMatchLabels: | |
# model: "mistral" | |
# | |
# vllmConfig: | |
# enableChunkedPrefill: false | |
# enablePrefixCaching: false | |
# maxModelLen: 16384 | |
# dtype: "bfloat16" | |
# extraArgs: ["--disable-log-requests", "--gpu-memory-utilization", "0.8"] | |
# | |
# lmcacheConfig: | |
# enabled: true | |
# cpuOffloadingBufferSize: "30" | |
# | |
# hf_token: <HUGGING_FACE_TOKEN> | |
# | |
# nodeSelectorTerms: | |
# - matchExpressions: | |
# - key: nvidia.com/gpu.product | |
# operator: "In" | |
# values: | |
# - "NVIDIA-RTX-A6000" |
Otherwise LGTM! Thanks for the contribution 🎉!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An image pull secret is needed to use a vllm image from a private repository. This PR introduces a small change to the helm chart allowing specification of an image pull secret
imagePullSecret
in amodelSpec
(where therepository
andtag
are specified).FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-s
when doinggit commit
[Bugfix]
,[Feat]
, and[CI]
.Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Feat]
for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]
for changes to thevllm_router
(e.g., routing algorithm, router observability, etc.).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-commit
to format your code. SeeREADME.md
for installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:
header which certifies agreement with the terms of the DCO.Using
-s
withgit commit
will automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.