Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate obcq path in favor of sparsegpt path #1148

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kylesayrs
Copy link
Collaborator

Purpose

Changes

  • Moved SparseGPTModifier from llmcompressor.modifiers.obcq to llmcompressor.modifiers.pruning.sparsegpt
  • Left a depreciation warning and backwards compatible import
warnings.warn(
    "llmcompressor.modifiers.obcq has been moved to "
    "llmcompressor.modifiers.pruning.sparsegpt Please update your paths",
    DeprecationWarning,
)

TODO

  • Rename/ fix bugs in tests

Testing

  • grepped codebase grep -r 'import SparseGPTModifier' src tests examples

Signed-off-by: Kyle Sayers <[email protected]>
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs added the ready When a PR is ready for review label Feb 14, 2025
)
from loguru import logger
from pydantic import PrivateAttr
from llmcompressor.modifiers.pruning.sparsegpt import SparseGPTModifier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kylesayrs kylesayrs removed the ready When a PR is ready for review label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants