Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use kwargs in autograd functions #3

Merged
merged 3 commits into from
May 27, 2024
Merged

Don't use kwargs in autograd functions #3

merged 3 commits into from
May 27, 2024

Conversation

Yard1
Copy link

@Yard1 Yard1 commented May 22, 2024 •
edited
Loading

Turns out this is not allowed!

@Yard1 Yard1 changed the title Don't use kwargs in autograd functions Don't use kwargs in autograd functions, fix out check May 22, 2024
@Yard1 Yard1 changed the title Don't use kwargs in autograd functions, fix out check Don't use kwargs in autograd functions May 22, 2024
WoosukKwon
WoosukKwon approved these changes May 27, 2024
View reviewed changes
Copy link

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@WoosukKwon WoosukKwon merged commit 03bf1f8 into vllm-project:main May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yard1 @WoosukKwon