High DPI Support #285
Merged
High DPI Support #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Tested on Ubuntu 20.04 with 4K screen, and it works. But user settings should probably also scale so the sizes don't change between sessions run on different screens. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the issue of scaling of fixed sizes on high DPI monitors. This is achieved by generally avoiding fixed size parameters, and where they cannot easily be avoided, use a function
pxInt()in the Config class to calculate the rounded and scaled value.Icons should now all scale to the
texticonSizeparameter that scales with the text. Margins should use the correct "fixed" value.The scale factor is calculated by dividing the Qt
logicalDotsPerInchXvalue by the normalised value of 96. This works fine on Debian (Gnome 3) but must be tested on other systems too.