Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all .po files translated into French. #2226

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

Karduin
Copy link
Contributor

@Karduin Karduin commented Feb 3, 2025

Summary:

This PR adds a translation in French of all .po files.
Change french translator author in docs/source/locales/authors_fr.conf.
I hope I did it right.

Related Issue(s):

Discussion #1834

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

Change french translator author.
@vkbo vkbo added this to the Release 2.7 Beta 1 milestone Feb 3, 2025
@vkbo
Copy link
Owner

vkbo commented Feb 3, 2025

Yeah, it looks good! I'll try building the manual, and update the auto-build for releases.

@vkbo vkbo merged commit 99db1a1 into vkbo:main Feb 3, 2025
8 checks passed
@vkbo
Copy link
Owner

vkbo commented Feb 3, 2025

By the way, you signed the commit with jim on linux <z******@****.fr>. You may want to associate that email address with your GitHub account. It helps to make it possible to see who made the commit, You may also want to change your commit email address to the anonymous one that GitHub provides.

Suggestion:

  1. Add the above email address here: https://github.com/settings/emails
  2. Enable the "Keep my email addresses private" setting and change your local config to the email listed in the text next to that option. It should consist of a number + your username + @users.noreply.github.com

It's just a suggestion to keep your address private. Let me know if you want me to revert your commit so you can make it again to hide the address. I can fix it if you decide quickly. 😃

Edit: Step 1 is enough to associate the commit with your user. If you don't mind the address being public in the repository, then that's all you need to do. I do prefer the commits being linked to an account. I just didn't notice it right away.

@Karduin
Copy link
Contributor Author

Karduin commented Feb 4, 2025

Oh yes, thank you.
I have made the modifications indicated.
I prefer to hide my address and redo the commit.
thanks again.

@vkbo
Copy link
Owner

vkbo commented Feb 4, 2025

Ok, I will roll back then. Make sure you haven't updated your fork yet, otherwise it will become invalid.

@vkbo
Copy link
Owner

vkbo commented Feb 4, 2025

Done. You can make the pull request again.

@vkbo
Copy link
Owner

vkbo commented Feb 4, 2025

Actually, looking at the forks, it is too late. I had to revert my revert. Rolling back a repo has to be done immediately after, otherwise it causes problems for forks,

@Karduin
Copy link
Contributor Author

Karduin commented Feb 4, 2025

Never mind! , I'll deal with it.

@vkbo
Copy link
Owner

vkbo commented Feb 4, 2025

Spammers do collect email addresses from repos on GitHub, but it isn't high risk like putting it on a website. You actually need to get into the commits to collect them. I've often used my real email too, especially when using it for work or university, and I rarely got any spam.

But I think it's smart to use the one GitHub provides for this purpose. I have a very long list of emails associated with my account from before they added this feature, and I can't clean them out because they are used in commits. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants