-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all .po files translated into French. #2226
Conversation
Change french translator author.
Yeah, it looks good! I'll try building the manual, and update the auto-build for releases. |
By the way, you signed the commit with Suggestion:
It's just a suggestion to keep your address private. Let me know if you want me to revert your commit so you can make it again to hide the address. I can fix it if you decide quickly. 😃 Edit: Step 1 is enough to associate the commit with your user. If you don't mind the address being public in the repository, then that's all you need to do. I do prefer the commits being linked to an account. I just didn't notice it right away. |
Oh yes, thank you. |
Ok, I will roll back then. Make sure you haven't updated your fork yet, otherwise it will become invalid. |
Done. You can make the pull request again. |
Actually, looking at the forks, it is too late. I had to revert my revert. Rolling back a repo has to be done immediately after, otherwise it causes problems for forks, |
Never mind! , I'll deal with it. |
Spammers do collect email addresses from repos on GitHub, but it isn't high risk like putting it on a website. You actually need to get into the commits to collect them. I've often used my real email too, especially when using it for work or university, and I rarely got any spam. But I think it's smart to use the one GitHub provides for this purpose. I have a very long list of emails associated with my account from before they added this feature, and I can't clean them out because they are used in commits. 😄 |
Summary:
This PR adds a translation in French of all .po files.
Change french translator author in docs/source/locales/authors_fr.conf.
I hope I did it right.
Related Issue(s):
Discussion #1834
Reviewer's Checklist: