Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with "create note from tag" #2215

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Fix issue with "create note from tag" #2215

merged 3 commits into from
Jan 30, 2025

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jan 30, 2025

Summary:

This PR fixes an issue where the create tag from note option was available for keywords for story and mention, but notes cannot be created for these. This PR also cleans up the trinary enum that isn't really needed any more with this change.

Related Issue(s):

Closes #2212

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6.1 milestone Jan 30, 2025
@vkbo vkbo linked an issue Jan 30, 2025 that may be closed by this pull request
@vkbo vkbo merged commit f103288 into release Jan 30, 2025
9 checks passed
@vkbo vkbo deleted the tag_creation branch January 30, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Note for Tag menu action and the new tag types
1 participant