Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows launcher, attempt 2 #2199

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Windows launcher, attempt 2 #2199

merged 4 commits into from
Jan 20, 2025

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jan 20, 2025

Summary:

This PR converts the launcher exe to a GUi launcher to avoid the terminal window popup, and adds the msvcp140.dll to the root of the install. It is already distributed with Qt6, but a copy is made to root. This should make the launcher work on computers without the redist package installed.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.7 Beta 1 milestone Jan 20, 2025
@vkbo vkbo merged commit 3672ae8 into main Jan 20, 2025
10 checks passed
@vkbo vkbo deleted the win_launcher2 branch January 20, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant