Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows exe launcher #2197

Merged
merged 10 commits into from
Jan 18, 2025
Merged

Windows exe launcher #2197

merged 10 commits into from
Jan 18, 2025

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jan 18, 2025

Summary:

This is a simple novelWriter.exe launcher that runs the embedded pythonw.exe with novelWriter.pyw and then exits. It also passes on the first command line argument, so it can accept a file path to load.

All of this works on my Windows 10 VM, but is highly experimental until properly tested.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.7 Beta 1 milestone Jan 18, 2025
@vkbo vkbo marked this pull request as draft January 18, 2025 01:03
@vkbo vkbo marked this pull request as ready for review January 18, 2025 13:58
@vkbo vkbo changed the title Draft: Windows exe launcher Windows exe launcher Jan 18, 2025
@vkbo vkbo merged commit b64bd38 into main Jan 18, 2025
8 checks passed
@vkbo vkbo deleted the windows_launcher branch January 18, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant