Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few minor issues with the new icon themes, and Qt6 theme support #2190

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jan 15, 2025

Summary:

This PR:

  • Updates the calculation of the different shade colours, which are based in the Window colour. If the Window colour is black, all shades are also black, rendering some widgets invisible.
  • Update how icon themes are handled. They are now consistent with other themes and have proper default fallbacks defined. Otherwise the icons would fall back to all red X-es.
  • Add support for user defined icon themes, as requested by @HeyMyian. The new themes are more complicated to make than the old one, but at least now there's the option. The only real difference is that the icons must now be SVG and must be in-lined in the theme file rather than be saved in individual SVG files.
  • Status LED colours are now taken from the default, red and green icon colours from the theme, and made a little darker.
  • The Solarized themes have been corrected a little based on the parent theme standard.
  • The status led colours have been removed from all themes, and a few minor adjustments made here and there.
  • The custom toggle switch has been modified a little. The thumb button is now always highlightedText colour, and the track uses alternateBase colour when off. It has also received a border using one of the button shades. All of this should improve visibility on all themes.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.7 Beta 1 milestone Jan 15, 2025
@vkbo vkbo merged commit a20508b into main Jan 15, 2025
7 checks passed
@vkbo vkbo deleted the theme_fixes branch January 15, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant