Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve document editing #2077

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Improve document editing #2077

merged 5 commits into from
Oct 30, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 30, 2024

Summary:

This PR includes various improvements to how documents are handled in the editor and main GUI:

  • The editor now has a signal emitted when documents are closed and opened.
  • The novel view now listens to this signal when highlighting the current document.
  • This feature has also been added to the project tree,
  • The opening and closing procedure for editor documents have been refactored a little.
  • The editor now uses the PyQt6 compliant wrapper for passing signals to non-slot functions.

Related Issue(s):

Closes #1981

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6 Beta 1 milestone Oct 30, 2024
@vkbo vkbo merged commit b529d5b into main Oct 30, 2024
9 checks passed
@vkbo vkbo deleted the active_document branch October 30, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Tree View: Edit Indicator
1 participant