Increase minimum Qt version to 5.10 #1174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR increases the minimum required Qt version to 5.10. This is still quite an old version (released 2017-11-30), but there is only one known place in novelWriter where a higher version is required, which is for the RegEx search to work properly with Unicode.
Technically, increasing to 5.9 would have been enough to avoid issues that reduces the functionality of novelWriter (older versions do not support non-breaking spaces the way novelWriter uses the document editor). However, with 5.10, a lot of version checks in the code can be omitted.
Ubuntu 18.04 comes with Qt 5.9.5, but from novelWriter 2.0 this Ubuntu release is not supported anyway since support for Python 3.6 has been dropped.
Related Issue(s):
Reviewer's Checklist: