Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum Qt version to 5.10 #1174

Merged
merged 5 commits into from
Oct 15, 2022
Merged

Increase minimum Qt version to 5.10 #1174

merged 5 commits into from
Oct 15, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 15, 2022

Summary:

This PR increases the minimum required Qt version to 5.10. This is still quite an old version (released 2017-11-30), but there is only one known place in novelWriter where a higher version is required, which is for the RegEx search to work properly with Unicode.

Technically, increasing to 5.9 would have been enough to avoid issues that reduces the functionality of novelWriter (older versions do not support non-breaking spaces the way novelWriter uses the document editor). However, with 5.10, a lot of version checks in the code can be omitted.

Ubuntu 18.04 comes with Qt 5.9.5, but from novelWriter 2.0 this Ubuntu release is not supported anyway since support for Python 3.6 has been dropped.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.0 RC 1 milestone Oct 15, 2022
@vkbo vkbo merged commit 559a179 into main Oct 15, 2022
@vkbo vkbo deleted the bump_min_qt_version branch October 15, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant