Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing space when auto-inserting space #1131

Merged
merged 4 commits into from
Oct 1, 2022
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 1, 2022

Summary:

This PR adds a simple look-back check to see if the character before the one that triggered the insertion of a non-breaking space was also a space character. If so, that character is removed before the new space is inserted.

Related Issue(s):

Resolves #1061

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 1.7 RC 1 milestone Oct 1, 2022
@vkbo vkbo merged commit 9c381c4 into main Oct 1, 2022
@vkbo vkbo deleted the remove_existing_space branch October 1, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove already present spaces when inserting non-breaking spaces
1 participant