Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context menu entries in project tree #1111

Merged
merged 2 commits into from
Sep 11, 2022
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Sep 11, 2022

Summary:

This PR makes the following changes:

  • The delete item menu entry for empty folders now correctly says "Delete Permanently" instead of "Move to Trash". Issue Empty folder context menu is inconsistent #1105.
  • The menu entries for changing document layout now stays "Convert to" instead of "Change to". It is technically just a change of a setting, but to the user it makes more sense to say convert.
  • The menu entries for status and importance now says "Set Status to ..." and "Set Importance to ..." instead of "Change [...] to" which is technically incorrect in the case where the user selects the same value as was previously set.

Related Issue(s):

Closes #1105

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 1.7 RC 1 milestone Sep 11, 2022
@vkbo vkbo merged commit c48d415 into main Sep 11, 2022
@vkbo vkbo deleted the delete_items_consistency branch September 11, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty folder context menu is inconsistent
1 participant