Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid path check to new project wizard #1062

Merged
merged 4 commits into from
May 15, 2022
Merged

Add valid path check to new project wizard #1062

merged 4 commits into from
May 15, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 15, 2022

Summary:

This PR adds a simple check for valid path to the New Project Wizard. It isn't perfect, but it will eliminate most cases where the Wizard is completed but the new project not created due to issues with the path.

This PR also rewrites the tests for the wizard.

Related Issue(s):

Resolves #1058

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 1.7 Beta 1 milestone May 15, 2022
@vkbo vkbo merged commit 304d122 into main May 15, 2022
@vkbo vkbo deleted the wizard_used_path branch May 15, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A new project in a location with an existing project fails after the wizard
1 participant