Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force consistency of item settings #1054

Merged
merged 3 commits into from
May 8, 2022
Merged

Force consistency of item settings #1054

merged 3 commits into from
May 8, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 8, 2022 •
edited
Loading

Summary:

This PR adds some checks to the loading of project items from XML to check that certain settings are consistent.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 1.7 Beta 1 milestone May 8, 2022
@vkbo vkbo merged commit 12cfce7 into main May 8, 2022
@vkbo vkbo deleted the item_checks branch May 8, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.7 Beta 1
Development

Successfully merging this pull request may close these issues.
1 participant
@vkbo