Use the random generator for item handles #1044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR changes the algorithm that generates item handles to instead use the built-in random number generator. The change is trivial and the new handles are on the same format as the old, so there is no conversion needed for existing projects.
The main changes in the PR is to the test suite, which now uses a mock random generator to run most tests. The mock generator just counts upwards on each call, which maks it easier to write testes containing handles and status or importance keys.
Related Issue(s):
Reviewer's Checklist: