Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify text labels in XML #1038

Merged
merged 3 commits into from
Apr 16, 2022
Merged

Simplify text labels in XML #1038

merged 3 commits into from
Apr 16, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Apr 16, 2022

Summary:

Since XML doesn't handle multiple spaces in text in a predictable manner, the item labels should use the new simplified function on all text labels. The same should apply to other user-defined strings in the project.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 1.7 Beta 1 milestone Apr 16, 2022
@vkbo vkbo merged commit b642e44 into main Apr 16, 2022
@vkbo vkbo deleted the item_updates branch April 16, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant