Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement the status and importance flags #1034

Merged
merged 10 commits into from
Apr 16, 2022
Merged

Re-implement the status and importance flags #1034

merged 10 commits into from
Apr 16, 2022

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Apr 5, 2022

Summary:

This PR completely rewrites the NWStatus class, the class that controls all the status and importance flags in the project.

With this change, the text of the label is no longer the information stored for each item in the project. Matching those with the pre-defined list was always a bit risky due to the way XML treats text. In this new implementation, each status or importance flag is given a key, which is either an "s" or an "i" followed by a random 24 bit value in hex. This decouples the visible label from the underlying flag, which means there is no need to update the values for the project items when a flag is re-labelled. It's the same logic that is used with the item labels themselves.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 1.7 Beta 1 milestone Apr 5, 2022
@vkbo vkbo changed the title Also update hidden status / import keys Re-implement the status and importance flags Apr 5, 2022
@vkbo vkbo merged commit c9f7fba into main Apr 16, 2022
@vkbo vkbo deleted the status_import_updates branch April 16, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant