-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple roots of same class #1031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files in the tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR allows each class of root folders to be added multiple times. For notes, this is trivial as no part of the code cares about what root folder a note is in, only what class the folder is. However, for novel documents, the outline and novel tree treats them all as one, which defeats the purpose of allowing multiple novels in one project.
To solve this, the items now track what root folder they belong to. This more or less renders the class setting redundant as it is determined by the root folder, but it is kept anyway because it is faster to look up directly than via the root folder handle. However, the synchronisation of these settings are updated each time an item is changed as well as at load time.
This PR also simplifies the creation of new items, and the updating of settings when an item is moved. A lot more decisions are now handled by the NWItem class itself. Most decisions are now taken in a central place instead of relying on a lot of in-place checks where changes to items are made. This significantly simplifies the logic in the project tree class for instance.
Due to these changes, several restrictions on drag and drop have been lifted. The remaining rules are:
Related Issue(s):
Resolves #967
Reviewer's Checklist: