Save both status and importance flags #1030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the old project file format, the status and importance flags were saved to the same setting in the project file, and interpreted as status or importance based on the class. This meant that if an item is moved from one class folder to another where the interpretation changes, and then back again, the setting is lost.
With the new file format, saving both is less of an issue, so the old setting is now preserved as long as the status or importance entry still exists in the project.
This PR also moves the handling of the status/importance icons from the main GUI class into the NWStatus class itself. This makes more sense, but was not done in the past in order to keep QtGui elements out of the novelWriter core subpackage. Since the issue there was mostly with testing, a quick hack has been added to the conftest.py file.
Related Issue(s):
Reviewer's Checklist: