Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: option panel overflow #989

Closed
ding0z opened this issue Feb 8, 2022 · 13 comments · Fixed by #1159
Closed

MacOS: option panel overflow #989

ding0z opened this issue Feb 8, 2022 · 13 comments · Fixed by #1159
Assignees
Labels
bug Issue: Something isn't working
Milestone

Comments

@ding0z
Copy link

ding0z commented Feb 8, 2022

While changing the default font, I've noticed that the option panel opens without full screen but without respecting the actual size of the screen. It is actually much wider. I have to resize it every time and pressing 'ok' doesn't seem to save the size of the panel.

This issue occurs on laptop with or without external monitor connected.

@ding0z ding0z added the bug Issue: Something isn't working label Feb 8, 2022
@vkbo
Copy link
Owner

vkbo commented Feb 8, 2022

Could you post a screenshot? I'm not sure I understand the issue.

Never mind, on a re-read I think I got it. It is the Preferences panel that is wider than the screen, is that right? Or is it the font options dialog box?

There are some issues related to DPI scaling. The support for high DPI screens is a bit quirky in Qt5 (see #864). It is fixed in Qt6. There is some additional code in novelWriter for managing it, but it isn't perfect.

@ding0z
Copy link
Author

ding0z commented Feb 8, 2022

It is related to the Preferences panel wider than the screen.
Even the font options dialog box becomes too small if I increase the font size too much, but that's easily fixable. Courier/Arial 14 for that works just fine.

@vkbo
Copy link
Owner

vkbo commented Feb 8, 2022

There may be a bug related to detecting UI scale on macOS. Could you start novelWriter from the command line with the --verbose flag? There should be a couple of lines in the verbose output stating the DPI and UI scale. The two lines should come fairly close to the top and state "VERBOSE GUI DPI:" and "VERBOSE GUI Scale:" and two numbers.

@ding0z
Copy link
Author

ding0z commented Feb 8, 2022

Here they are:

[2022-02-08 16:09:59,926] theme.py:142 VERBOSE GUI DPI: 72.0
[2022-02-08 16:09:59,926] theme.py:143 VERBOSE GUI Scale: 0.75

@vkbo
Copy link
Owner

vkbo commented Feb 8, 2022

You can see yourself how messy all of this is in Qt5: https://doc.qt.io/qt-5/highdpi.html

I have an issue up to review the implementation (#864). I'll bump it up in my ToDo list. The problem is that there are various solutions depending on which minor version of Qt5 you're on, and a macOS solution that requires the plist file to be present. Since novelWriter isn't properly bundled for macOS, this file does not currently exist.

Since Qt5 is no longer under development, and Qt 5.15 is the LTS release, I could probably further restrict the minimum vrsion requirement to 5.6 and see if I can find a consistent way of handling DPI scaling. Apparently all of this is simpler in Qt6.

@ding0z
Copy link
Author

ding0z commented Feb 9, 2022

Sure. Not a bit problem anyway. A double click to the title bar brings everything back to normal.

@vkbo vkbo self-assigned this May 26, 2022
@vkbo vkbo added this to the Release 1.7 RC 1 milestone May 26, 2022
@vkbo
Copy link
Owner

vkbo commented Oct 11, 2022

I discovered a potential bug in the preferences and project settings dialogs that may have caused this. Is the issue still present in the current main branch?

@ding0z
Copy link
Author

ding0z commented Oct 12, 2022

Yes, still present. (v1.6.4)

@vkbo
Copy link
Owner

vkbo commented Oct 12, 2022

No, I meant in the current main branch, if you are able to test. If not, it can wait until the next release.

Hmm, never mind. I think I found another bug that may explain it.

@ding0z
Copy link
Author

ding0z commented Oct 12, 2022

You mean the 1.7 Beta 1?

@vkbo
Copy link
Owner

vkbo commented Oct 12, 2022

No, I mean the current source code. But never mind, I think I spotted the actual issue now, and will fix it for the next release. I may do a 1.6.5 as well since there are a couple of minor bugs that need fixing.

@ding0z
Copy link
Author

ding0z commented Oct 12, 2022

Ah, I understand. Ok, I'll wait and report in case once the 1.6.5 is available.

@vkbo vkbo modified the milestones: Release 2.0 RC 1, Release 1.6.5 Oct 13, 2022
@vkbo vkbo mentioned this issue Oct 13, 2022
6 tasks
@vkbo
Copy link
Owner

vkbo commented Oct 13, 2022

Fixed and released as 1.6.5.

@vkbo vkbo closed this as completed Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants